fix: run-tests script with xdebug version >= 3.0.0#6022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Xdebug configuration for versions 3.0+
When running
./start.shwith Xdebug 3 or higher, the test suite fails with the following error:[BORK] Xdebug: [Config] The setting 'xdebug.default_enable' has been renamed, see the upgrading guide at https://xdebug.org/docs/upgrade_guide#changed-xdebug.default_enable (See: https://xdebug.org/docs/errors#CFG-C-CHANGED)According to the Xdebug upgrade guide:
https://xdebug.org/docs/upgrade_guide#Changed-Configuration-Settings
The configuration setting has changed in Xdebug 3.
This PR updates the configuration used by the test environment so that when Xdebug version 3.0.0 or higher is detected,
xdebug.mode=offis used instead ofxdebug.default_enable=0.This prevents the configuration warning and allows the test suite to run normally.